feat: Native Send Component #1874
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brendan-defi
force-pushed
the
bf/ock-send
branch
from
bf2eb1f to
bb6562d
Compare
brendan-defi
force-pushed
the
bf/ock-send
branch
from
342bbfb to
95ee15c
Compare
brendan-defi
force-pushed
the
bf/ock-send
branch
from
95ee15c to
43a0f8a
Compare
brendan-defi
force-pushed
the
bf/ock-send
branch
from
c444463 to
353a8e8
Compare
alessey
reviewed
Feb 3, 2025
| showSend, | ||
| setShowSend, | ||
| isSendClosing, | ||
| setIsSendClosing, |
There was a problem hiding this comment.
could probably simplify these, since you only ever show a single thing at a time, only really need a single isClosing and setIsClosing, probably possible to also have a single show: 'qr' | 'send' | 'swap' and setShow(type: 'qr' | 'send' | 'swap'), would make adding additional types easier.
alessey
reviewed
Feb 3, 2025
| const { tokenBalances } = useWalletAdvancedContext(); | ||
| const context = useSendContext(); | ||
|
|
||
| const walletHasEth = context.isInitialized && context.ethBalance > 0.000001; |
There was a problem hiding this comment.
why 0.000001? may want to extract to a const, MIN_ETH_TO_SEND
alessey
reviewed
Feb 3, 2025
| setValidatedInput, | ||
| handleRecipientInputChange, | ||
| className, | ||
| }: AddressInputProps) { |
alessey
reviewed
Feb 3, 2025
| selectedRecipientAddress: RecipientAddress; | ||
| recipientInput: string; | ||
| setRecipientInput: Dispatch<SetStateAction<string>>; | ||
| setValidatedInput: Dispatch<SetStateAction<RecipientAddress>>; |
There was a problem hiding this comment.
if the intention by passing props is to allow this to be reusable, would be better to make these standard callbacks vs. setState callbacks
alessey
reviewed
Feb 3, 2025
| inputMode="text" | ||
| placeholder="Basename, ENS, or Address" | ||
| value={displayValue} | ||
| inputValidator={() => !!validateAddressInput(recipientInput)} |
There was a problem hiding this comment.
inputValidator={(value) => !!validateAddressInput(value)}
alessey
reviewed
Feb 3, 2025
| cryptoAmount={cryptoAmount ?? ''} | ||
| exchangeRate={exchangeRate} | ||
| exchangeRateLoading={false} | ||
| currency={'USD'} |
alessey
reviewed
Feb 3, 2025
| address: AddressType | null; | ||
| senderChain: Chain | null | undefined; | ||
| handleClick: () => Promise<void>; | ||
| }; |
alessey
reviewed
Feb 3, 2025
| fiatAmount={fiatAmount ?? ''} | ||
| cryptoAmount={cryptoAmount ?? ''} | ||
| asset={selectedToken?.symbol ?? ''} | ||
| currency={'USD'} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?